Summary: | The marker '----' is not removed for CHECKIN and CHECKOUT | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices
Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices [PASSED QA] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices |
Description
Jonathan Druart
2014-12-31 12:25:14 UTC
Created attachment 34846 [details] [review] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. Created attachment 34851 [details] [review] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 34896 [details] [review] [PASSED QA] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.3 Pushed to 3.16.x, will be in 3.16.7 |