Bug 13504

Summary: The marker '----' is not removed for CHECKIN and CHECKOUT
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: NoticesAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, mtj, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices
Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices
[PASSED QA] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices

Description Jonathan Druart 2014-12-31 12:25:14 UTC
If there is only 1 item, the marker is not removed.
Comment 1 Jonathan Druart 2014-12-31 12:27:48 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2015-01-01 06:17:21 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2015-01-02 15:54:47 UTC
Created attachment 34896 [details] [review]
[PASSED QA] Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices

If only 1 item exist in the message, the marker is not removed.
This marker is removed by render_metadata, but this method is only
called on appending.

Test plan:
1/ Enable the CHECKIN and/or CHECKOUT notices for a patron
2/ check and item in or out and verify that the marker is no longer
displayed in the generated notices.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2015-01-04 15:20:40 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 5 Chris Cormack 2015-01-05 23:09:00 UTC
Pushed to 3.18.x will be in 3.18.3
Comment 6 Mason James 2015-01-16 21:16:44 UTC
Pushed to 3.16.x, will be in 3.16.7