| Summary: | Sip/Configuration/*.pm classes are unused | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14644 | ||
| Attachments: |
Proposed patch
Bug 13506: Remove unused Sip/Configuration Classes [PASSED QA] Bug 13506: Remove unused Sip/Configuration Classes Bug 13506 [QA Follouwp] - Fix POD |
||
|
Description
Colin Campbell
2015-01-02 10:21:34 UTC
Created attachment 34858 [details] [review] Proposed patch Removes the unused classes, remove the useless calls to their new methods. Took advantage to remove other obsolete code from configuration Simple Test plan: Select a repeatable series of sip transactions (e.g. an issue and discharge) run before applying patch to confirm all ok, run after applying patch and server should behave identically Created attachment 35943 [details] [review] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> There is 1 occurrence of Sip::Configuration::Institution left in C4/SIP/ILS.pod. Maybe should it be removed? Created attachment 36083 [details] [review] [PASSED QA] Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 36084 [details] [review] Bug 13506 [QA Follouwp] - Fix POD Patches pushed to master. Thanks Colin! |