|
Description
Kyle M Hall (khall)
2015-01-05 15:10:45 UTC
Created attachment 34954 [details] [review] Bug 13516 - Tidy relevant code black Created attachment 34955 [details] [review] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Created attachment 34956 [details] [review] Bug 13516 - Tidy relevant code block Created attachment 34957 [details] [review] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Created attachment 35097 [details] [review] [SIGNED OFF] Bug 13516 - Tidy relevant code block Signed-off-by: Nick <nick@quecheelibrary.org> Created attachment 35098 [details] [review] [SIGNED OFF] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick <nick@quecheelibrary.org> I am not sure I understand this correctly.
1) With and without the patch my staff result list for the checked out item with lost status = 1 looks the same:
2 items, 1 available:
Books Midway Book Cart (1)
Books
1 on loan:
Computer Files Midway Book Cart (1) date due: 11/01/2015
Computer Files
Should we not include the information that the item is lost somehow?
Please take a look and explain!
This patch fixes the mangled display. With the patch, you will still see the lost status. See this screenshot: http://content.screencast.com/users/kylemhall/folders/Jing/media/891a082f-1c71-4207-b01c-44b27b465fd8/00000017.png (In reply to Katrin Fischer from comment #7) > I am not sure I understand this correctly. > > 1) With and without the patch my staff result list for the checked out item > with lost status = 1 looks the same: > > 2 items, 1 available: > > Books Midway Book Cart (1) > Books > > 1 on loan: > > Computer Files Midway Book Cart (1) date due: 11/01/2015 > Computer Files > > > Should we not include the information that the item is lost somehow? > > Please take a look and explain! Created attachment 38776 [details] [review] [PASSED QA] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=13561 Created attachment 38777 [details] [review] [PASSED QA] Bug 13516 - Tidy relevant code block Signed-off-by: Nick <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38778 [details] [review] [PASSED QA] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Kyle! Pushed to 3.18.x will be in 3.18.7 |
