Summary: | Date sorting on accounts (fines) tab doesn't work correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, the.invinnysible.one, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly
wrongly sorted dates in accountlines [PASSED QA] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly |
Description
Katrin Fischer
2015-01-06 21:34:55 UTC
Created attachment 35004 [details] [review] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. We all tryed to recreate the bug but were unable to replicate it. Created attachment 35137 [details]
wrongly sorted dates in accountlines
Thx for testing! It's easier to see when you have a lot of different dates and change the dateformat system preference to "dd/mm/yyyy".
Created attachment 35358 [details] [review] [PASSED QA] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes sorting problem. Created attachment 35377 [details] [review] Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes sorting problem. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I must note I was not able to reproduce the issue, even with dd/mm/yyyy, I got: 15/07/2013 11/06/2014 20/08/2014 19/01/2015 I can confirm this patch introduces the correct way to sort dates with datatables and I did not find any regression. Marked as Passed QA Patch pushed to master. Thanks Owen! Pushed to 3.18.x will be in 3.18.4 |