| Summary: | Typo in bulkmarcimport | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | MARC Bibliographic record staging/import | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, the.invinnysible.one, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
bug 13530: Typo in bulkmarcimport
k [PASSED QA] bug 13530: Typo in bulkmarcimport [SIGNED-OFF] bug 13530: Typo in bulkmarcimport bug 13530: Typo in bulkmarcimport Bug 13530: Typo in bulkmarcimport |
||
|
Description
Martin Renvoize (ashimema)
2015-01-07 13:27:13 UTC
Hint: Line 401 the GetFrameworkcode function is has one wrong case character ;) Will attempt to correct problem. Created attachment 35132 [details] [review] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. Created attachment 35143 [details] [review] k Created attachment 35144 [details] [review] [PASSED QA] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 35145 [details] [review] [SIGNED-OFF] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> My colleague who uses this script often is now very happy.. thanks :) I'll try to poke someone in to QA this today, as as the reporter I think that rules me out. Cheers (In reply to the.invinnysible.one from comment #4) > Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. Hi mysterious author, Is there a chance to get a patch with your correct name? The patch's author is Some <some.name@example.org> Created attachment 35170 [details] [review] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Jonathan Druart from comment #9) > (In reply to the.invinnysible.one from comment #4) > > Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. > > Hi mysterious author, > Is there a chance to get a patch with your correct name? > The patch's author is Some <some.name@example.org> My apologies, I have fixed the author name on the patch now. :-) Created attachment 35174 [details] [review] Bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note that I did not test this patch, because I never user bulkmarcimport. But the fix is trivial and makes sense. (In reply to Martin Renvoize from comment #8) > I'll try to poke someone in to QA this today, as as the reporter I think > that rules me out. Where did you read that? I am not sure at all this rules exists :) (In reply to Jonathan Druart from comment #14) > (In reply to Martin Renvoize from comment #8) > > I'll try to poke someone in to QA this today, as as the reporter I think > > that rules me out. > > Where did you read that? > I am not sure at all this rules exists :) Just had a hunch it might be one.. if not then I could have QA'd it.. oops. Thnaks anyway Jonathan Patch pushed to master. Thanks Morag, and congratulations! Pushed to 3.18.x, will be in the 3.18.3 release so your code will be out in use by libraries around the world by the end of January, Morag |