| Summary: | Table patroncards not used | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Database | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13539 - Remove unused table patroncards
Bug 13539 - Remove unused table patroncards Bug 13539 - Remove unused table patroncards Bug 13539: (RM followup) DBIx schema update |
||
|
Description
Katrin Fischer
2015-01-08 15:37:30 UTC
<chris_n> hmm... that table appears to be vestigial <chris_n> mysql> SELECT count(*) FROM patroncards; <chris_n> +----------+ <chris_n> | count(*) | <chris_n> +----------+ <chris_n> | 5 | <chris_n> +----------+ <chris_n> 1 row in set (0.00 sec) <chris_n> but the timestamps are from 2008 <chris_n> and grep shows no code referencing that table And so this table may safetly be removed, IMHO. Created attachment 35351 [details] [review] Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. I'd consider the batch data kind of temporary as it's only needed for printing. There is no way to clean out the old data from within Koha and it's not been accessible in the GUI apart from reports for a long time. If someone sees a reason to be more careful here, please comment :) Test plan: - Check the table exists in your database - Run the database update - Confirm the table has been deleted - Verify the table is not necessary for printing patroncards (using the feature and/or checking the codebase) - Make sure the web installer still works correctly on creating a new database, but that patroncards is no longer created Created attachment 36153 [details] [review] Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Removes the tables. Seems safe to delete to me too, while testing through the patrons Created attachment 36158 [details] [review] Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 37769 [details] [review] Bug 13539: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. Thanks Katrina! |