Summary: | admin/auth_subfields_structure.pl does not compile in older perls | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13544: Make it explicit that getauthtypes returns a hash ref
[SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref [PASSED QA] Bug 13544: Make it explicit that getauthtypes returns a hash ref |
Description
Jonathan Druart
2015-01-09 14:53:27 UTC
Created attachment 35088 [details] [review] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Not sure how to test this, my system uses perl 5.18, but I found no regressions in editing the authority frameworks. You can use sandboxes, they use perl 5.10.1 Created attachment 35419 [details] [review] [SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed problem and tested patch on a sandbox, signed off locally. Created attachment 35570 [details] [review] [PASSED QA] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed problem and tested patch on a sandbox, signed off locally. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA on this.. simple patch that fixes the problem. Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.4 |