Summary: | "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Circulation | Assignee: | Eivin Giske Skaaren <eivin> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, eivin, gitbot, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 13548: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. |
Description
Barton Chittenden
2015-01-09 19:43:24 UTC
Created attachment 42442 [details] [review] Bug 13548: "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. This solves the problem since there was a boolean check that evaluated to false because of the 0. To test: 1. Apply patch. 2. Enable decreaseLoanHighHolds and set decreaseLoanHighHoldsValue to 0. 3. Check out an item without holds and see that the behaviour is now correct. Is this fixed somewhere else? If not this should be very easy for someone to sign off.. Quite a big conflict in C4::Circulation sorry I updated to latest master and tested the behaviour. Setting decreaseLoanHighHoldsValue to 0 does not trigger the message anymore and I can also see in Circulation.pm in the checkHighHolds subroutine that the code has changed and that this issue probably was fixed by that. So I am closing the ticket as resolved - worksforme. |