| Summary: | History file should be open using utf-8 encoding | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | About | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11944, 13596 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13579: Open history.txt using utf-8 encoding
[SIGNED OFF] Bug 13579: Open history.txt using utf-8 encoding Bug 13579: Open history.txt using utf-8 encoding Bug 13579: (regression tests) Encoding issues on about > timeline get tested Bug 13579: (regression tests) Encoding issues on about > timeline get tested Bug 13579: Prefer like instead of ok to match a regex |
||
|
Description
Jonathan Druart
2015-01-14 12:48:29 UTC
Created attachment 35184 [details] [review] Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded Created attachment 35185 [details] [review] [SIGNED OFF] Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 35186 [details] [review] Bug 13579: Open history.txt using utf-8 encoding Test plan: Verify about>Timeline is correctly encoded Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Replaced <encoding by <:encoding. Created attachment 35195 [details] [review] Bug 13579: (regression tests) Encoding issues on about > timeline get tested This patch introduces two tests for encoding issues on about > timeline To test: - Apply the patch and run $ KOHA_USER=kohaadmin KOHA_PASS=katikoan KOHA_INTRANET_URL=http://koha-dev.biblioadmin prove t/db_dependent/www/history.t (adjust to your own settings, the user needs to have access to the about page) Regards Signed-off-by: Manuel Cohen Arazi <manuelcohenarazi@gmail.com> Created attachment 35209 [details] [review] Bug 13579: (regression tests) Encoding issues on about > timeline get tested This patch introduces two tests for encoding issues on about > timeline To test: - Apply the patch and run $ KOHA_USER=kohaadmin KOHA_PASS=katikoan KOHA_INTRANET_URL=http://koha-dev.biblioadmin prove t/db_dependent/www/history.t (adjust to your own settings, the user needs to have access to the about page) Regards Signed-off-by: Manuel Cohen Arazi <manuelcohenarazi@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 35210 [details] [review] Bug 13579: Prefer like instead of ok to match a regex Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patches pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.3 |