Description
Martin Renvoize (ashimema)
2015-01-15 09:54:15 UTC
Created attachment 35318 [details] [review] Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL Comment on attachment 35318 [details] [review] Bug 13586: Makefile.PL mentions win32 Review of attachment 35318 [details] [review]: ----------------------------------------------------------------- ::: Makefile.PL @@ -1481,4 @@ > unless exists $skip_directories->{$key}; > } > } > - elsif ($^O eq 'MSWin32' ) { # On Win32, the install probably needs to be done under the user account koha will be running as... What's done in this block should be removed too. Created attachment 35947 [details] [review] Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. Created attachment 35948 [details] [review] Bug 13586: Remove some other occurrences Created attachment 36697 [details] [review] [SIGNED OFF] Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Created attachment 36698 [details] [review] [SIGNED OFF] Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Created attachment 36699 [details] [review] [SIGNED OFF] Bug 13586: Remove some other occurrences Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Created attachment 36907 [details] [review] [PASSED QA] Bug 13586: Makefile.PL mentions win32 Edited Makefile.PL to remove mentions of win32 To test: Run Makefile.PL Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 36908 [details] [review] [PASSED QA] Bug 13586: Remove the entire block Previous patch remove the condition but not the block tested. The entire block should be removed. Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 36909 [details] [review] [PASSED QA] Bug 13586: Remove some other occurrences Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Rochele! Pushed to 3.18.x will be in 3.18.5 Pushed to 3.16.x, will be in 3.16.9 |