Summary: | Rss sample templates have hardcoded urls | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | OPAC | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, eivin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch
Bug 13591 Pass OPACBaseURL to rss creation process [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process |
Description
Colin Campbell
2015-01-16 17:12:18 UTC
Created attachment 36762 [details] [review] Proposed patch Simple to test Generating an xml file without the patch (e.g. ./rss.pl ./lastAcquired-1.0.conf ) creates an xhtml page with all the links going to library.org.nz Doing the same with the patch applied and all links should be to the site's own opac as specified in OPACBaseURL Created attachment 38902 [details] [review] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Corrected Eivin's sign off, by obsoleting unsigned version, and marking unsigned. Enjoy QA'ing. :) Created attachment 38972 [details] [review] [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Good catch Colin! Pushed to 3.18.x will be in 3.18.7 |