Bug 13591

Summary: Rss sample templates have hardcoded urls
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: OPACAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: chris, eivin, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Proposed patch
Bug 13591 Pass OPACBaseURL to rss creation process
[PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process

Description Colin Campbell 2015-01-16 17:12:18 UTC
The sample templates in misc/cronjobs/rss have hardcoded urls the should be using suspref OPACBaseURL

The contents of rss are rather neglected but many sites seem to want to use this, while most may want some customizations the samples should work out of the box in a sensible fashion at present if you create a list of new acquisitions The links are hardcoded to nz
Comment 1 Colin Campbell 2015-03-10 12:25:05 UTC Comment hidden (obsolete)
Comment 2 Eivin Giske Skaaren 2015-05-06 18:53:36 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2015-05-07 19:22:14 UTC
Corrected Eivin's sign off, by obsoleting unsigned version, and marking unsigned. Enjoy QA'ing. :)
Comment 4 Kyle M Hall 2015-05-08 12:23:50 UTC
Created attachment 38972 [details] [review]
[PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process

Links in rss templates were hardcoded to library.org.nz. Should pass and
use the system's OPACBaseURL.

Tested and verified.

Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2015-05-15 19:12:16 UTC
Patch pushed to master.

Good catch Colin!
Comment 6 Chris Cormack 2015-05-17 23:35:29 UTC
Pushed to 3.18.x will be in 3.18.7