| Summary: | 'Stock number' should be 'Inventory number' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, julian.maurice, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13593: 'stock number' should be 'inventory number'
[Signed-off] Bug 13593: 'stock number' should be 'inventory number' Bug 13593: 'stock number' should be 'inventory number' Bug 13593: (follow-up) 'stock number' should be 'inventory number' |
||
|
Description
Katrin Fischer
2015-01-18 19:02:09 UTC
Failing to trigger this one: koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: [% INCLUDE itemsearch_header name='stocknumber' label='stock number' text='Stock number' %] Created attachment 35347 [details] [review] Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order http://bugs.koha-community.org/show_bug.cgi?id=13564 (In reply to Katrin Fischer from comment #1) > Failing to trigger this one: > koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_items.inc: > [% INCLUDE itemsearch_header name='stocknumber' label='stock number' > text='Stock number' %] Julian, Could you please have a look? It seems that the script catalogue/itemsearch.pl is never caller with format="html". Actually the html value is set in the form, but it is DT that calls the script with format="json". (In reply to Jonathan Druart from comment #3) > Julian, > Could you please have a look? It seems that the script > catalogue/itemsearch.pl is never caller with format="html". > Actually the html value is set in the form, but it is DT that calls the > script with format="json". format="html" is a fallback mode for when javascript is disabled. Try disabling JS and reload the page. Created attachment 35998 [details] [review] [Signed-off] Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. http://bugs.koha-community.org/show_bug.cgi?id=13564 Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 36041 [details] [review] Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 36042 [details] [review] Bug 13593: (follow-up) 'stock number' should be 'inventory number' Add one more. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patches pushed to master. Thanks Katrina! String changes, held for 3.18.5 Pushed to 3.18.x will be in 3.18.5 |