Summary: | Turn 'Suspend' action for holds into a button in the OPAC user account | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, gmcharlt, lisettepalouse+koha, pasi.kallinen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Christopher Brannon
2015-01-23 00:00:49 UTC
Maybe 'suspend item' instead? I am not sure about changing the wording to have 'click' - it would also make for an awful long translation in German. (In reply to Katrin Fischer from comment #1) > Maybe 'suspend item' instead? I am not sure about changing the wording to > have 'click' - it would also make for an awful long translation in German. Also, why state something that should be obvious - if the user doesn't know it's a clickable element, something is seriously wrong with the element style. (In reply to paxed from comment #2) > something is seriously wrong with the element > style. And since it is styled as a link just like any other, there shouldn't be ambiguity about its being clickable. In general I think it's not useful to tell users to click things... Especially since many of our users now use touches instead of mouse clicks. Another option is to style it as a button. (In reply to Owen Leonard from comment #3) > (In reply to paxed from comment #2) > > something is seriously wrong with the element > > style. > > And since it is styled as a link just like any other, there shouldn't be > ambiguity about its being clickable. In general I think it's not useful to > tell users to click things... Especially since many of our users now use > touches instead of mouse clicks. > > Another option is to style it as a button. IF we are concerned about touches, IMO, we should try to stay away from links and use buttons everywhere. Buttons are more touch friendly. Unfortunately, if people took the time to look things over better, I wouldn't even be reporting this. I think that is crazy that there are people trying to read books, but can't read the controls on a screen. With that said, if a button is favored over making the link a more obvious action with words, then go for it. It really does look confusing as is. Even the staff side of things makes more sense. Christopher I was able to modify the link to look like a button for the time being with jQuery, to see how that flies with patrons: //Change Suspend/Resume link to button $("#holdst td:nth-of-type(6) a,#holdst td:nth-of-type(6) button").removeClass("btn-link"); //end Change suspend link A couple odd things I notice. The class I remove is forcing it to look like a link. When I remove the class, it turns into a button! I also notice that Suspend is a an anchor tag and the Resume is a button tag. Very unusual and inconsistent. Christopher > I also notice that Suspend is a an anchor tag and the Resume is a button
> tag. Very unusual and inconsistent.
The suspend link is a trigger to a modal form. It could be anything--<button>, <input>, <a>... JavaScript doesn't care. If there is a consensus that it is more logical to present it as a button we can do that. The suspend link doesn't even show up if JavaScript is disabled.
The resume button is an actual button which controls submission of a form. It works with and without JavaScript enabled.
In both cases the element is being styled as what it is--a link and a button.
Is this still valid? The wording hasn't changed but I believe the icons would help enforce the action of the link? I think the display has probably changed since this was first filed. Currently it looks like this: https://snipboard.io/2ZejIW.jpg Since cancel and the suspend options below the table are buttons, maybe it would still make sense to update the link to a button too. |