| Summary: | Enhance html for holds queue viewer | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Hold requests | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13623 - Enhance html for holds queue viewer
Bug 13623 - Enhance html for holds queue viewer Bug 13623 - Enhance html for holds queue viewer [Signed-off] Bug 13623 - Enhance html for holds queue viewer [PASSED QA] Bug 13623 - Enhance html for holds queue viewer Bug 13623: Follow-up: remove stray </p> tag |
||
|
Description
Kyle M Hall (khall)
2015-01-26 16:28:46 UTC
Created attachment 35540 [details] [review] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div Created attachment 35541 [details] [review] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Created attachment 37845 [details] [review] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div NOTE: Hopefully rebased well. :) Created attachment 37849 [details] [review] [Signed-off] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div HTML appears as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 38143 [details] [review] [PASSED QA] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div HTML appears as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38144 [details] [review] Bug 13623: Follow-up: remove stray </p> tag Just removing a stray </p> tag. I got problems when trying to check this page with an HTML validator, would probaby be worth checking. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Bywater! |