|
Description
Katrin Fischer
2015-02-02 17:10:35 UTC
Sorry but... how you do this
> - create a member of organisation type patron
> - link second patron to your created organisation patron
http://manual.koha-community.org/3.18/en/patscirc.html Organizational Organizational patrons are organizations. Organizations can be used as guarantors for Professional patrons. Professional Professional patrons can be linked to Organizational patrons I tested with a School (Category School (SC)) and a Teacher (Category Teacher (T)) As far as I understand it's the same functionality as for Garantors? - But there the button seems to translate to "Ändern" in German. I think the untranslated text only appeared after I had linked the guarantor/parent, but appeared translated in the beginning. I suspected a Javascript problem. I have retested this. With the sample data: - Search for an existing 'Kid' patron - buttons display as 'Ändern' and 'Löschen' - click 'Ändern' - Search for an adult patron to link to and confirm - Suddenly instead of 'Ändern', there is 'Change' Strange, I see the similar behavior but with "set to patron" string... Created attachment 39208 [details] [review] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Created attachment 39209 [details] [review] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Created attachment 39215 [details] [review] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization Created attachment 39216 [details] [review] [SIGNED-OFF] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization Created attachment 39534 [details] [review] Bug 13656: "Change"/"Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable Test plan: 1. install and activate an additional language 2. create patron in organization category 3. create professional patron 4. try to add this patron to an organization (Guarantor information section) 5. note that the left button text changed to "Change" - untranslated english string 6. push the "Delete" button, the guarantor patron field is cleared and the left button text changed to "Set to patron" - again original english text 7. apply the patch 7.1. update translation (koha-translate -u language_code) 8. repeat 4-6, note, that button text are still translated in all sitations 9. sign off ;) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors Fixed message capitalization Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Josef! Pushed to 3.20.x will be in 3.20.1 Hi, This patch doesn't apply for 3.18. If you feel that it should be included, please resolve any issues and resubmit a patch for inclusion in 3.18.x. Liz Created attachment 40160 [details] [review] Bug 13656: "Set to patron" button for linking a member to an organisation (or child to guarantor) not translatable - 3.18.x The 3.18.x code does not content the javascript for updating button string to 'Change', so I made the 3.18.x version of this patch just for 'Set to patron' string. The non translatable 'Change' string was added by bug 13021 |