| Summary: | Remove useless constraint in Koha::Schema::Result::Biblio | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11518 | ||
| Bug Blocks: | 13923 | ||
| Attachments: |
Bug 13713: WIP - Remove useless constraints previously added
Bug 13713: Follow-up removing biblioitem routines [PASSED QA] Bug 13713: Follow-up removing biblioitem routines |
||
|
Description
Jonathan Druart
2015-02-16 15:40:01 UTC
Created attachment 35949 [details] [review] Bug 13713: WIP - Remove useless constraints previously added This patch removes the 3 constraints added by patch from bug 11518. Having 1-n + 1-1 relations for the same field is a non-sense. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a follow-up for removing some unneeded code. Created attachment 35950 [details] [review] Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 36089 [details] [review] [PASSED QA] Bug 13713: Follow-up removing biblioitem routines There is no need to define biblioitem routines, if we can access them via biblioitemnumber. Note that we actually need a FK for biblio in the items table. Now we do need the intermediate level via biblioitems in the Items.t code. Even better, we should move biblioitem to biblio. Formally it is 1-n, but in reality it is 1-1. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Please rebase this one. First patch was missing. Patches pushed to master. Thanks Jonathan and Marcel! |