| Summary: | Suggestions reason doesn't save | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12627 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13731: Suggestions reason does not save on updating the status
[Signed-off] Bug 13731: Suggestions reason does not save on updating the status [PASSED QA] Bug 13731: Suggestions reason does not save on updating the status |
||
|
Description
Josef Moravec
2015-02-19 11:20:01 UTC
When viewing accepted suggestions in the staff client you should see a "status" column which includes the reason which was specified when the suggestion was accepted. The information is stored in the "reason" column in the suggestions table. Are you not seeing it like that, or are you expecting it to display somewhere else? I can't see it anywhere... and in the database, in table suggestions, i have just NULL value in column reason in every row. Hi Owen and Josef, I just tested this after some weirdness seen in training. I can confirm the problem: It's not really a display problem, but if you accept/reject a suggestion right now, the reason doesn't seem to get saved into the suggestion at all :( I did a git bisect as I couldn't spot the problem right away, it points to: 1c2744a83f99027386f9409ad43e725707ae45f8 is the first bad commit commit 1c2744a83f99027386f9409ad43e725707ae45f8 Author: Yohann Dufour <dufour.yohann@gmail.com> Date: Fri Aug 8 15:11:18 2014 +0200 Bug 12627: SQLHelper replacement - C4::Suggestions ... I fail to spot the problem, could someone else please take a look? Created attachment 36119 [details] [review] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Created attachment 36140 [details] [review] [Signed-off] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 36281 [details] [review] [PASSED QA] Bug 13731: Suggestions reason does not save on updating the status On the suggestion list view, if you set a status, it won't be saved. Test plan: 1/ Create a suggestion 2/ Go on the suggestion list view (suggestion/suggestion.pl) 3/ Select a suggestion and marked it as "rejected" (or the status you want) and choose a reason 4/ Save 5/ Browse you suggestions DB table (using your favorite MySQL CLI) and verify that the "reason" field is correctly filled. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, thx! Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.5 Possible selection for 3.16.x (In reply to Mason James from comment #11) > Possible selection for 3.16.x bug does not exist in 3.16.9 - so skipping patch |