| Summary: | Fix problems with frequency descriptions containing quotes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Serials | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, jonathan.druart, mtj, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13747: Fix problems with frequency descriptions containing quotes
Bug 13747: Fix problems with frequency descriptions containing quotes |
||
Created attachment 63955 [details] [review] Bug 13747: Fix problems with frequency descriptions containing quotes If a serial frequency description contains quotes or is surrounded by quotes, the description is empty ("TEST" > empty) or shown without the quotes part (TEST "sth" > TEST) on editing the frequency. To verify: - Create a new frequency with description: "Test" - Modify frequency - Verify the description field is empty To test: - Apply patch - Try to recreate, verify that the description field is correctly filled when editing - Test also with a name like: 'A "souble quoted" name' Created attachment 63986 [details] [review] Bug 13747: Fix problems with frequency descriptions containing quotes If a serial frequency description contains quotes or is surrounded by quotes, the description is empty ("TEST" > empty) or shown without the quotes part (TEST "sth" > TEST) on editing the frequency. To verify: - Create a new frequency with description: "Test" - Modify frequency - Verify the description field is empty To test: - Apply patch - Try to recreate, verify that the description field is correctly filled when editing - Test also with a name like: 'A "souble quoted" name' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 17.11, thanks to everybody involved! Pushed to 17.05.x, will be in 17.05.01 This patch has been pushed to 16.11.x and will be in 16.11.09. Pushed to 16.05.x, for 16.05.15 release |
Found this by coincidence during training: If a serial frequency description contains quotes or is surrounded by quotes, the description is empty ("TEST" > empty) or shown without the quotes part (TEST "sth" > TEST) on editing the frequency. To test: - Create a new frequency - description: "Test" - Modify frequency - Verify the description field is empty