| Summary: | On loading holds in patron account 'processing' is not translatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, hayleypelham, jonathan.druart, kyle, lucas, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00, 19.05.06, 18.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 13749: On loading holds in patron account 'processing' is not translatable
Bug 13749: On loading holds in patron account 'processing' is not translatable Bug 13749: On loading holds in patron account 'processing' is not translatable |
||
|
Description
Katrin Fischer
2015-02-22 10:21:50 UTC
This is also true for the 'Loading...' shown directly inside the table. I tried looking at the code, but not sure why some strings appear to work and others not. Could someone else take a look? Just a guess: git grep 'Loading\.\.\.' The (long) result list contains following files. I have the impression that they are not translated. koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.jeditable.mini.js Created attachment 93889 [details] [review] Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. Created attachment 94964 [details] [review] Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx, Owen! Created attachment 95139 [details] [review] Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It does not appear on moremember, any ideas why? Nice work! Pushed to master for 19.11.00 backported to 19.05.x for 19.05.06 Backported 18.11.x for 18.11.12 |