Summary: | in quotes.tt line 14 the use of \" break the translation | ||
---|---|---|---|
Product: | Koha | Reporter: | Christophe Croullebois <christophe.croullebois> |
Component: | Templates | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, chris, christophe.croullebois, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
proposed patch
[SIGNED-OFF] Bug 13768: Correction of double quotes escaped into double quotes [PASSED QA] Bug 13768: Correction of double quotes escaped into double quotes |
Description
Christophe Croullebois
2015-02-27 15:42:27 UTC
Created attachment 36766 [details] [review] proposed patch Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); Test plan : without patch : 1/ in English pages go to tools/Edit quotes for QOTD feature 2/ create some quotes if there is no 3/ you must have at least 2 languages translated 4/ try with a language translated the page quotes.pl 5/ you must have the translated page broken (message charging... in the table, no use possible in the page) if no try another language With the patch : same steps 1-5 5/ the translated pages must be ok thx for testing Created attachment 36770 [details] [review] [SIGNED-OFF] Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> diff on staff PO file -msgid "" -"No quotes available. Please use the \\\"Add quote\\\" button to add a quote." +#, fuzzy +msgid "No quotes available. Please use the 'Add quote' button to add a quote." No koha-qa errors Created attachment 36905 [details] [review] [PASSED QA] Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> diff on staff PO file -msgid "" -"No quotes available. Please use the \\\"Add quote\\\" button to add a quote." +#, fuzzy +msgid "No quotes available. Please use the 'Add quote' button to add a quote." No koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Christophe! Pushed to 3.18.x will be in 3.18.6 |