Summary: | RSS for news needs a bit of styling | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Circulation function: | |||
Bug Depends on: | 7843, 22568 | ||
Bug Blocks: | |||
Attachments: |
display of rss
Bug 13782: RSS for news needs a bit of styling Bug 13782: RSS for news needs a bit of styling Bug 13782: RSS for news needs a bit of styling |
I agree it could be a little confusing because the info is so close together (news and main content) Created attachment 86925 [details] [review] Bug 13782: RSS for news needs a bit of styling This patch makes a number of updates to the display of news in the OPAC. I hope that this makes OPAC news nicer/easier to read. It includes style changes to make the RSS link look better too. To test, apply the patch and regenerate the OPAC CSS. You should have multiple active news items. View the OPAC news with varied values of NewsAuthorDisplay and OpacNewsLibrarySelect. Test the single news item view. Test with Quotes on and off, and with OpacMainUserBlock populated or not. 86925 - Bug 13782: RSS for news needs a bit of styling Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13782: RSS for news needs a bit of styling Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt Could you try it again? It applies fine for me. THis applies fine for me as well, with the dependency bugs applied - so can test. :) Created attachment 87424 [details] [review] Bug 13782: RSS for news needs a bit of styling This patch makes a number of updates to the display of news in the OPAC. I hope that this makes OPAC news nicer/easier to read. It includes style changes to make the RSS link look better too. To test, apply the patch and regenerate the OPAC CSS. You should have multiple active news items. View the OPAC news with varied values of NewsAuthorDisplay and OpacNewsLibrarySelect. Test the single news item view. Test with Quotes on and off, and with OpacMainUserBlock populated or not. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 87428 [details] [review] Bug 13782: RSS for news needs a bit of styling This patch makes a number of updates to the display of news in the OPAC. I hope that this makes OPAC news nicer/easier to read. It includes style changes to make the RSS link look better too. To test, apply the patch and regenerate the OPAC CSS. You should have multiple active news items. View the OPAC news with varied values of NewsAuthorDisplay and OpacNewsLibrarySelect. Test the single news item view. Test with Quotes on and off, and with OpacMainUserBlock populated or not. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Awesome work all! Pushed to master for 19.05 Minor enhancement, will not be backported to 18.11.x series. |
Created attachment 36387 [details] display of rss It looks like the RSS feed for the news items could use a bit of styling because right now it is right up against the main body content and that is confusing. I'd say the icon should be at the top of the news on the right or in the opac footer instead of right below the news.