Summary: | SelfCheck not setting flag when item requires transit | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, colin.campbell, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed Patch
Bug 13803 Flag to self check book has gone into transit Bug 13803 Flag to self check book has gone into transit |
Description
Colin Campbell
2015-03-06 10:01:15 UTC
Created attachment 36665 [details] [review] Proposed Patch Trivial patch adding check of this status to others already included. Can have a big impact on libraries with lots of selfcheck machines and users able to return other than home branch Created attachment 37756 [details] [review] Bug 13803 Flag to self check book has gone into transit Ensure that the transit flag (in field CV) is set if return message is 'wasTransfered' CV is being set for other return conditions but not for wasTransfered [sic] The presence of this flag is required to route returns to the correct bin if the SC unit is so enabled Signed-off-by: Frederic Demians <f.demians@tamil.fr> I agree with the solution to an issue I've already encountered and patched localy that way. It would be nice to have a better doc of C4::Circulation::AddReturn in order to see immediately that WasTransfered is a valid feedback for a check-in. Kyle or Brendan, could one of you take a look at this please? Created attachment 37936 [details] [review] Bug 13803 Flag to self check book has gone into transit Ensure that the transit flag (in field CV) is set if return message is 'wasTransfered' CV is being set for other return conditions but not for wasTransfered [sic] The presence of this flag is required to route returns to the correct bin if the SC unit is so enabled Signed-off-by: Frederic Demians <f.demians@tamil.fr> I agree with the solution to an issue I've already encountered and patched localy that way. It would be nice to have a better doc of C4::Circulation::AddReturn in order to see immediately that WasTransfered is a valid feedback for a check-in. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Patch pushed to master. Thanks Colin! Pushed to 3.18.x will be in 3.18.6 |