Summary: | Missing table header IDs on record holdings table in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | OPAC | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, tomascohen, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13832 - Missing table header IDs on record holdings table in OPAC
[Signed-off] Bug 13832 - Missing table header IDs on record holdings table in OPAC [PASSED QA] Bug 13832 - Missing table header IDs on record holdings table in OPAC |
Description
Kyle M Hall (khall)
2015-03-13 13:53:30 UTC
Created attachment 36861 [details] [review] Bug 13832 - Missing table header IDs on record holdings table in OPAC All but two of the table headers in the item holdings table in the opac have identifiers. The remaining two should be added so they can be modified easily with CSS. Test Plan: 1) Apply this patch 2) View the holdings table for a record 3) Note the new id field for the item holds column 4) Note the new id field for the hold prioirty column ( if enabled ) Created attachment 37168 [details] [review] [Signed-off] Bug 13832 - Missing table header IDs on record holdings table in OPAC All but two of the table headers in the item holdings table in the opac have identifiers. The remaining two should be added so they can be modified easily with CSS. Test Plan: 1) Apply this patch 2) View the holdings table for a record 3) Note the new id field for the item holds column 4) Note the new id field for the hold prioirty column ( if enabled ) Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37200 [details] [review] [PASSED QA] Bug 13832 - Missing table header IDs on record holdings table in OPAC All but two of the table headers in the item holdings table in the opac have identifiers. The remaining two should be added so they can be modified easily with CSS. Test Plan: 1) Apply this patch 2) View the holdings table for a record 3) Note the new id field for the item holds column 4) Note the new id field for the hold prioirty column ( if enabled ) Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This is all ok, but can you please add matching classes to the <tr> tags like we have it for the other columns? This way the complete column can be hidden/influenced with CSS. Sorry, missed we already got one... ignore last comment. Time to go to sleep :) Patch pushed to master. Thanks ByWaterians! Pushed to 3.18.x will be in 3.18.6 |