| Summary: | Allow svc/report to be passed sql parameters for non-public reports | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Reports | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | tmisilo, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13880 - Allow svc/report to be passed sql parameters
Bug 13880 - Allow svc/report to be passed sql parameters Bug 13880 - Allow svc/report to be passed sql parameters |
||
|
Description
Kyle M Hall (khall)
2015-03-20 13:47:30 UTC
Created attachment 37042 [details] [review] Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response Created attachment 37390 [details] [review] Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the Staff URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response NOTE: without applying the patch you get an empty JSON response. ALSO: running koha qa tools does not verify the changes. $ perlcritic -4 svc/report (my perlcritic rc points to the koha qa tool one) No issues. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38170 [details] [review] Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the Staff URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response NOTE: without applying the patch you get an empty JSON response. ALSO: running koha qa tools does not verify the changes. $ perlcritic -4 svc/report (my perlcritic rc points to the koha qa tool one) No issues. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch pushed to master. Thanks Kyle! |