| Summary: | Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian FIOL <julian.fiol> |
| Component: | Test Suite | Assignee: | Julian FIOL <julian.fiol> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | aleisha, julian.maurice, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields
Bug 13882 : Adding new unit tests in t/Borrower.t Bug 9120: Prevent form submission on adding tags - OPAC [PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t Bug 13882 - Tidy t/Borrower.t to fix whitespace errors |
||
|
Description
Julian FIOL
2015-03-20 15:29:43 UTC
Created attachment 37054 [details] [review] Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields Created attachment 37366 [details] [review] Bug 13882 : Adding new unit tests in t/Borrower.t This adds testing for all the 'borrower' database fields. TEST PLAN --------- 1) apply patch 2) prove -v t/Borrowers.t -- All 67 subtests for both the setter and accessor should run successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 37394 [details] Bug 9120: Prevent form submission on adding tags - OPAC At the OPAC, if the user adds tags pressing 'Enter', the page is reloaded and the tags are not added. To prevent that, this patch suggests to block the "press enter" event on the inputs. Test plan: 0/ Confirm the bad behavior, without this patch. 1/ Apply this patch and confirm nothing happen on pressing enter when the focus is on the add tag input (At the opac, on the result view). Patch works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> All tests pass, signing off. Created attachment 37470 [details] [review] [PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t This adds testing for all the 'borrower' database fields. TEST PLAN --------- 1) apply patch 2) prove -v t/Borrowers.t -- All 67 subtests for both the setter and accessor should run successfully. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 37471 [details] [review] Bug 13882 - Tidy t/Borrower.t to fix whitespace errors |