Bug 13882

Summary: Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields
Product: Koha Reporter: Julian FIOL <julian.fiol>
Component: Test SuiteAssignee: Julian FIOL <julian.fiol>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: trivial    
Priority: P5 - low CC: aleisha, julian.maurice, tomascohen
Version: master   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields
Bug 13882 : Adding new unit tests in t/Borrower.t
Bug 9120: Prevent form submission on adding tags - OPAC
[PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t
Bug 13882 - Tidy t/Borrower.t to fix whitespace errors

Description Julian FIOL 2015-03-20 15:29:43 UTC
Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields
Comment 1 Julian FIOL 2015-03-20 15:34:32 UTC Comment hidden (obsolete)
Comment 2 M. Tompsett 2015-03-30 12:55:10 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2015-03-31 02:58:34 UTC Comment hidden (obsolete)
Comment 4 Aleisha Amohia 2015-03-31 03:46:19 UTC
All tests pass, signing off.
Comment 5 Kyle M Hall 2015-04-03 17:41:21 UTC
Created attachment 37470 [details] [review]
[PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t

This adds testing for all the 'borrower' database fields.

TEST PLAN
---------
1) apply patch
2) prove -v t/Borrowers.t
   -- All 67 subtests for both the setter and accessor
      should run successfully.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2015-04-03 17:41:28 UTC
Created attachment 37471 [details] [review]
Bug 13882 - Tidy t/Borrower.t to fix whitespace errors
Comment 7 Tomás Cohen Arazi 2015-04-08 15:23:27 UTC
Patches pushed to master.

Good job Julian!

Note: I rebased it on top of bug 13928, no big deal.