Description
Nick Clemens (kidclamp)
2015-03-21 14:54:18 UTC
Created attachment 37078 [details] [review] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Nick I think 'Standard search' Should be Search the Catalog like on all other pages. I know it can be confusing to have that word in 2 searches, but I think we need to be consistent. Created attachment 37386 [details] [review] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected All tabs work - except check in which gives me this error: Software error: Can't bless non-reference value at /home/nengard/kohaclone/C4/ItemType.pm line 64. For help, please send mail to the webmaster (webmaster@koha-vm), giving this error message and the time and date of the error. Not my bug causing it, problem is on master (bug 13943) , but can't test until that is cleared What is the bug number? that one doesn't exist, I was going to add it as a dependency here. Nicole (In reply to Nicole C. Engard from comment #6) > What is the bug number? that one doesn't exist, I was going to add it as a > dependency here. > > Nicole 13934, stupid fingers Bug 13934 is in master. It solves check-in error. Created attachment 37675 [details] [review] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Added search options work properly, and are consistently named. Created attachment 38037 [details] [review] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Added search options work properly, and are consistently named. Created attachment 38038 [details] [review] Bug 13885 [QA Followup] - Remove tab, remove unnecessary permission check Created attachment 38039 [details] [review] [PASSED QA] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians <f.demians@tamil.fr> - Added search options work properly, and are consistently named. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 38040 [details] [review] [PASSED QA] Bug 13885 [QA Followup] - Remove tab, remove unnecessary permission check Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Nick! |