Bug 13892

Summary: SQLHelper replacement - C4::Members::Search - ysearch.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: PatronsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, katrin.fischer, kyle.m.hall, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12633, 13822, 13957    
Attachments: Bug 13892: Make ysearch.pl not using C4::Members::Search
Bug 13892: Make ysearch.pl not using C4::Members::Search
[Signed-off] Bug 13892: Make ysearch.pl not using C4::Members::Search
[PASSED QA] Bug 13892: Make ysearch.pl not using C4::Members::Search

Description Jonathan Druart 2015-03-23 12:13:36 UTC
ysearch.pl currently uses C4::Members::Search.
To get rid of SQLHelper, we should not use this subroutine anymore.
Comment 1 Jonathan Druart 2015-03-23 12:16:39 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2015-03-23 14:05:05 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-03-24 10:21:42 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2015-03-27 15:23:42 UTC
Created attachment 37329 [details] [review]
[PASSED QA] Bug 13892: Make ysearch.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan:
0/ Enable the CircAutocompl pref
1/ Go on the circulation home page, or the reserve page
2/ Search for a patron and wait for the autocompletion box
3/ Confirm there is no regression

Works as expected.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2015-03-30 16:21:33 UTC
Patch pushed to master.

Thanks Jonthan!