| Summary: | Remove unused code in moremember.pl related to permission | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5986 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13898: Remove CANDELETEUSER code
[Signed-off] Bug 13898: Remove CANDELETEUSER code [PASSED QA] Bug 13898: Remove CANDELETEUSER code |
||
|
Description
Jonathan Druart
2015-03-24 09:56:45 UTC
Created attachment 37167 [details] [review] Bug 13898: Remove CANDELETEUSER code This code is never used. The permission to delete a patron is now done in members-toolbar.inc using CAN_user_borrowers. It's the good way to do. Test plan: git grep CANDELETEUSER should not return any result Created attachment 37169 [details] [review] [Signed-off] Bug 13898: Remove CANDELETEUSER code This code is never used. The permission to delete a patron is now done in members-toolbar.inc using CAN_user_borrowers. It's the good way to do. Test plan: git grep CANDELETEUSER should not return any result Followed test plan. No CANDELETEUSER found. Signed-off-by: Marc Véron <veron@veron.ch> I was curious, as this code looks basically right, but is not used, as you pointed out. This is the commit that added it to Koha: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=05b61e4f3a57828d0bc7d400cfc4bb97c4402a71 It seems to have been broken sometime between 3.10 - 3.12: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=8fd75227fcd87d2cea5d0cb31d7af72498fbb24d;hp=25232635f538ffb5582f56536c242d48f433018b#patch2 I wondered... should we bring it back instead of deleting it? I think it would just affect the behaviour for the IndependentBranches (not being able to delete another branches users). But I guess in order to make this really work consistently, we'd have to add this variable to all the .pl scripts on the various pages that show the members toolbar? This might be the reason why this has been removed in the first place. Passing QA... but leaving my notes here :) Created attachment 37199 [details] [review] [PASSED QA] Bug 13898: Remove CANDELETEUSER code This code is never used. The permission to delete a patron is now done in members-toolbar.inc using CAN_user_borrowers. It's the good way to do. Test plan: git grep CANDELETEUSER should not return any result Followed test plan. No CANDELETEUSER found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #3) > I wondered... should we bring it back instead of deleting it? It's not used, so we can delete it. If the IndependentBranches has to be checked (and I think it should), please open a new bug report. But... This exists for 2 years now and it does not seem to affect people. I agree... also the old code is not clean as it would only cover one page. - So I passed QA :) Patch pushed to master. Thanks Jonathan! |