|
Description
Frédéric Demians
2015-03-25 12:39:26 UTC
Created attachment 37212 [details] [review] Bug 13904 unimarc_field_4XX plugin doesn't display volume info, neither link to biblio When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Created attachment 39241 [details] [review] [SIGNED-OFF] Bug 13904: unimarc_field_4XX plugin doesn't display volume info, neither link to biblio When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> I can see 200$h and 200$i on search results, but not on result list from 4XX plugin, but they are copied into 46X. The title is now a link, so I think could be my example record. At last one of the problems is fixed :) No koha-qa errors Tested on UNIMARC setup, french files. Frédéric, I get the link, but not 200$h$i Could you please detail where volume is mapped with them? (In reply to Jonathan Druart from comment #3) > Frédéric, > I get the link, but not 200$h$i > Could you please detail where volume is mapped with them? It isn't... And, as you know, it can't be mapped to 2 distinct biblio record subfields. With this patch, biblioitems.volume is displayed after title. The goal is to disambiguate search results. By default, biblioitems.volume is mapped to 200$e (complément du titre). But in some installations, it can be mapped to $h or $i at convenience. If you think it's limiting, I could propose a counter patch displaying $a, $h, and $i. (In reply to Frédéric Demians from comment #4) > (In reply to Jonathan Druart from comment #3) > > Frédéric, > > I get the link, but not 200$h$i > > Could you please detail where volume is mapped with them? > > It isn't... And, as you know, it can't be mapped to 2 distinct biblio record > subfields. I just tried to understand your patch :) It only adds "resul.volume" to the TT, and I don't see any places where 200$h or $i could be assigned to resul.volume. From the test plan: "- You get a result list, with two issues: 1. $h & $i aren't displayed" Is this wrong? If not, I don't understand how I could see them displayed. > From the test plan:
> "- You get a result list, with two issues:
> 1. $h & $i aren't displayed"
> Is this wrong? If not, I don't understand how I could see them displayed.
It's wrong. See my above comment.
So please provide a valid test plan. Created attachment 39539 [details] [review] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Created attachment 39772 [details] [review] [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. Comment on attachment 39772 [details] [review] [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data Review of attachment 39772 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt @@ +174,5 @@ > + [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %] > + [% IF ( resul.place ) %] ; [% resul.place %][% END %] > + [% IF ( resul.pages ) %] - [% resul.pages %][% END %] > + [% IF ( resul.notes ) %] : [% resul.notes %][% END %] > + [% IF ( resul.size ) %] ; [% resul.size %][% END %] These lines remove the changes introduced by bug 13129, is it expected? (In reply to Jonathan Druart from comment #10) > Comment on attachment 39772 [details] [review] [review] > [SIGNED-OFF] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield > data > > Review of attachment 39772 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/ > unimarc_field_4XX.tt > @@ +174,5 @@ > > + [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %] > > + [% IF ( resul.place ) %] ; [% resul.place %][% END %] > > + [% IF ( resul.pages ) %] - [% resul.pages %][% END %] > > + [% IF ( resul.notes ) %] : [% resul.notes %][% END %] > > + [% IF ( resul.size ) %] ; [% resul.size %][% END %] > > These lines remove the changes introduced by bug 13129, is it expected? Do you mean the last line? => result.size commit c4095f55ad98cad41a546654fdc8829110599575
Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt
- <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]<
- <p>[% resul.author %]
- [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %]
- [% IF ( resul.place ) %] ; [% resul.place %][% END %]
- [% IF ( resul.pages ) %] - [% resul.pages %][% END %]
- [% IF ( resul.notes ) %] : [% resul.notes %][% END %]
- [% IF ( resul.size ) %] ; [% resul.size %][% END %]
+ <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |uri %]">[% resul.title |html %]<
+ <p>[% resul.author |html %]
+ [% IF ( resul.publishercode ) %]- [% resul.publishercode |html %][% END %]
+ [% IF ( resul.place ) %] ; [% resul.place |html %][% END %]
+ [% IF ( resul.pages ) %] - [% resul.pages |html %][% END %]
+ [% IF ( resul.notes ) %] : [% resul.notes |html %][% END %]
+ [% IF ( resul.item('size') ) %] ; [% resul.item('size') |html %][% END %]
Created attachment 40269 [details] [review] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. Created attachment 40313 [details] [review] Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h & $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Thanks Frédéric for you reactivity! Patch pushed to master. Thanks Frederic! |