| Summary: | Noisy t/Borrower tests | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | aleisha, josef.moravec, kyle, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13928: Clean up noisy t/Borrower.t tests
Bug 13928: Clean up noisy t/Borrower.t tests Bug 9120: Prevent form submission on adding tags - OPAC Bug 9120: Prevent form submission on adding tags - OPAC [SIGNED-OFF] Bug 13928: Clean up noisy t/Borrower.t tests Bug 13928: Clean up noisy t/Borrower.t tests |
||
|
Description
Mark Tompsett
2015-03-30 13:04:04 UTC
Created attachment 37367 [details] [review] Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There shoud be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Created attachment 37368 [details] [review] Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Created attachment 37397 [details] [review] Bug 9120: Prevent form submission on adding tags - OPAC At the OPAC, if the user adds tags pressing 'Enter', the page is reloaded and the tags are not added. To prevent that, this patch suggests to block the "press enter" event on the inputs. Test plan: 0/ Confirm the bad behavior, without this patch. 1/ Apply this patch and confirm nothing happen on pressing enter when the focus is on the add tag input (At the opac, on the result view). Patch works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> http://bugs.koha-community.org/show_bug.cgi?id=13882 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 37398 [details] Bug 9120: Prevent form submission on adding tags - OPAC At the OPAC, if the user adds tags pressing 'Enter', the page is reloaded and the tags are not added. To prevent that, this patch suggests to block the "press enter" event on the inputs. Test plan: 0/ Confirm the bad behavior, without this patch. 1/ Apply this patch and confirm nothing happen on pressing enter when the focus is on the add tag input (At the opac, on the result view). Patch works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com> http://bugs.koha-community.org/show_bug.cgi?id=13882 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> All tests pass, signing off. Created attachment 37565 [details] [review] [SIGNED-OFF] Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Created attachment 37586 [details] [review] Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Works as expected Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. Thanks Mark! They annoy me too! |