|
Description
Josef Moravec
2015-03-30 20:31:25 UTC
Created attachment 37801 [details] [review] Bug 13931 - Added date of birth to member's search results table (intranet/cgi-bin/koha/members/member.pl) Created attachment 37807 [details] [review] Bug 13931 - Added patron's dateofbirth to autocomplete Created attachment 37809 [details] [review] Bug 13931 - Implemented patron's dateofbirth autocompletion into newest version of circ/ysearch.pl Created attachment 37811 [details] [review] Bug 13931 - Implemented date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Created attachment 38045 [details] Bug 13931 - Fixed Licence & Copyright statements & refactored the code Created attachment 38126 [details]
Columns wrong in result table
In cgi-bin/koha/members/member.pl the birth date displays in the column "Category" and an empty column is added.
Created attachment 44691 [details] [review] Bug 13931 - Fix patron search result table heading, fix member.pl template params Created attachment 44692 [details] [review] Bug 13931 - Implemented date of birth in patron search result and in autocomplete Created attachment 44693 [details] [review] Bug 13931 - Fix patron search result table heading, fix member.pl template params I've rebased patchs on top of current master and made followup to fix the error in patron search results table heading. Comment 7 issue is solved. Could you merge your 2 patches in one single patch? and include your test plan into the patch itself? Remarque: Admin > Column settings > Patrons > memberresultst is respected in normal patron search result table: you can hide the new column dateofbirth if necessary. But this is not respected by the autocompletion search result. From my point of view, it's an issue. But it's worth noting. Created attachment 44817 [details] [review] Bug 13931 - Date of birth in patron search result and in autocomplete Created attachment 44818 [details] [review] Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Thanks for testing Frédéric. I squashed the commits and again rebased on master. I think the autocomplete is not configurable at all, so we could open new bug, if somebody need it. > I think the autocomplete is not configurable at all, so we could open new
> bug, if somebody need it.
The other option would be to not add the date of birth to the autocompletion. I wrote earlier by mistake: "From my point of view, it's an issue." I think exactly the contrary, IMO it's NOT an issue. The date of birth doesn't take that much space, and add a valuable information on the autocompletion search result.
Created attachment 44821 [details] [review] Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. Created attachment 45062 [details] [review] Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 45065 [details] [review] Bug 13931 [QA Followup] - Fix whitespace error Pushed to master, thanks Josef! |