Summary: | Branch email hints are misleading | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | System Administration | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gmcharlt, katrin.fischer, kyle, mtj, mtompset, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 13968 - Branch email hints are misleading
Bug 13968 - Branch email hints are misleading Bug 13968 - Branch email hints are misleading Bug 13968: Follow up - Clean HTML tags for hints Bug 13968 - Branch email hints are misleading Bug 13968: Follow up - Clean HTML tags for hints |
Description
Martin Renvoize
2015-04-08 12:51:35 UTC
Created attachment 60432 [details] [review] Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, endit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Comment on attachment 60432 [details] [review] Bug 13968 - Branch email hints are misleading Review of attachment 60432 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ +186,5 @@ > <li><label for="branchphone">Phone: </label><input type="text" name="branchphone" id="branchphone" size="60" value="[% library.branchphone |html %]" /></li> > <li><label for="branchfax">Fax: </label><input type="text" name="branchfax" id="branchfax" size="60" value="[% library.branchfax |html %]" /></li> > <li><label for="branchemail">Email: </label><input type="text" name="branchemail" id="branchemail" class="email" size="80" value="[% library.branchemail |html %]" /></li> > + <li><label for="branchreplyto">Reply-To: </label> <input type="text" name="branchreplyto" id="branchreplyto" class="email" size="80" value="[% library.branchreplyto |html %]" /><br /><span class="hint"></hint>Default: ReplyToDefault system preference</li> > +</li> Extra </li>? Created attachment 60531 [details] [review] Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra </li> - 2017-02-21 mv Extra </li> removed, switching back to NSO Created attachment 60534 [details] [review] Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra </li> - 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 60535 [details] [review] Bug 13968: Follow up - Clean HTML tags for hints Should have been /span not /hint. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> (In reply to M. Tompsett from comment #6) > Created attachment 60535 [details] [review] [review] > Bug 13968: Follow up - Clean HTML tags for hints > > Should have been /span not /hint. > > Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Thanks, Mark, for fixing the /span issue, and sorry about, I was in a hurry. Created attachment 60637 [details] [review] Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra </li> - 2017-02-21 mv Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 60638 [details] [review] Bug 13968: Follow up - Clean HTML tags for hints Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Marc, Mark! This patch has been pushed to 16.11.x and will be in 16.11.05. Pushed to 16.05.x, for 16.05.11 release |