Bug 13981

Summary:	Transliterate rule for oe and ae
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Searching	Assignee:	Fridolin Somers <fridolin.somers>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	chris, nick, tomascohen, veron
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 13981 - Transliterate rule for oe and ae [Signed-off] Bug 13981 - Transliterate rule for oe and ae [PASSED QA] Bug 13981 - Transliterate rule for oe and ae

Description Fridolin Somers 2015-04-13 10:14:58 UTC

In ICU configuration, add a transliterate rule for œ = oe and æ = ae.

Comment 1 Fridolin Somers 2015-04-13 10:28:02 UTC Comment hidden (obsolete)

Created attachment 37718 [details] [review]
Bug 13981 - Transliterate rule for oe and ae

NOTE : I use HTML codes for special characters to avoir encoding issues in patch file.

In ICU configuration, add a transliterate rule for
&oelig; = oe
&aelig; = ae

Test plan :
- Without patch
- Create a record R1 with title containing for example "c&oelig;ur"
- Create a record R2 with title containing for example "coeur"
- Index those records
- Search for "c&oelig;ur"
=> You only find R1
- Search for "coeur"
=> You only find R2
- Apply patch
- Restart zebra
- Index R1 and R2
- Search for "c&oelig;ur"
=> You find R1 and R2
- Search for "coeur"
=> You find R1 and R2
(Same test plan for ae)

Comment 2 Marc Véron 2015-04-16 07:17:28 UTC Comment hidden (obsolete)

Created attachment 37943 [details] [review]
[Signed-off] Bug 13981 - Transliterate rule for oe and ae

NOTE : I use HTML codes for special characters to avoir encoding issues in patch file.

In ICU configuration, add a transliterate rule for
&oelig; = oe
&aelig; = ae

Test plan :
- Without patch
- Create a record R1 with title containing for example "c&oelig;ur"
- Create a record R2 with title containing for example "coeur"
- Index those records
- Search for "c&oelig;ur"
=> You only find R1
- Search for "coeur"
=> You only find R2
- Apply patch
- Restart zebra
- Index R1 and R2
- Search for "c&oelig;ur"
=> You find R1 and R2
- Search for "coeur"
=> You find R1 and R2
(Same test plan for ae)

------
Tested with all variants of Ae ae Oe oe. Search worked as expected.
Note: The words with special characters were not highlighted, but I think this can be done in an other bug.
Signed-off-by: Marc Véron <veron@veron.ch>

Comment 3 Kyle M Hall (khall) 2015-04-17 10:55:01 UTC

Created attachment 38031 [details] [review]
[PASSED QA] Bug 13981 - Transliterate rule for oe and ae

NOTE : I use HTML codes for special characters to avoir encoding issues in patch file.

In ICU configuration, add a transliterate rule for
&oelig; = oe
&aelig; = ae

Test plan :
- Without patch
- Create a record R1 with title containing for example "c&oelig;ur"
- Create a record R2 with title containing for example "coeur"
- Index those records
- Search for "c&oelig;ur"
=> You only find R1
- Search for "coeur"
=> You only find R2
- Apply patch
- Restart zebra
- Index R1 and R2
- Search for "c&oelig;ur"
=> You find R1 and R2
- Search for "coeur"
=> You find R1 and R2
(Same test plan for ae)

------
Tested with all variants of Ae ae Oe oe. Search worked as expected.
Note: The words with special characters were not highlighted, but I think this can be done in an other bug.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-04-20 13:29:55 UTC

Patch pushed to master.

Merci, Frido!

Comment 5 Chris Cormack 2015-04-22 05:41:17 UTC

Pushed to 3.18.x will be in 3.18.6