|
Description
Katrin Fischer
2015-04-16 11:10:25 UTC
Created attachment 40051 [details] [review] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Created attachment 40052 [details] [review] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Created attachment 40055 [details] [review] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 40198 [details] [review] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 40199 [details] [review] Bug 14002: Display readonly values as plain text There is no need to display the cardnumber and expiration date values in a disabled input. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> (In reply to Jonathan Druart from comment #5) > Created attachment 40199 [details] [review] [review] > Bug 14002: Display readonly values as plain text > > There is no need to display the cardnumber and expiration date values in > a disabled input. > > Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Katrin, What about this patch? I don't understand why the readonly values are displayed in a disabled input. I copied mine from the cardnumber to be honest - will try to check your patch asap :) Created attachment 40405 [details] [review] [PASSED QA] Bug 14002: Show patron expiry date in OPAC This patch makes it possible to show the expiration date of a patron account in the OPAC on the details tab in the patron account. Extras: - Makes it possible to hide cardnumber with PatronSelfRegistrationBorrowerUnwantedField To test: - Toggle OPACPatronDetails and test date expiry always shows - Check PatronSelfRegistrationBorrowerUnwantedField for dateexpiry and cardnumber - Verify a patron address modification request still works as expected Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 40406 [details] [review] [PASSED QA] Bug 14002: Display readonly values as plain text There is no need to display the cardnumber and expiration date values in a disabled input. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Katrina! Pushed to 3.20.x will be in 3.20.2 |