| Summary: | about.pl checks the wrong zebra index mode | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | About | Assignee: | Nicole C. Engard <nengard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, eivin, mtj, mtompset, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14006: about.pl checks the wrong zebra index mode
Bug 14006: about.pl checks the wrong zebra index mode [PASSED QA] Bug 14006: about.pl checks the wrong zebra index mode |
||
Created attachment 38207 [details] [review] Bug 14006: about.pl checks the wrong zebra index mode This trivial patch makes the about page correctly test for configuration mismatches. Specifically it fixes the situation in which the koha-config.xml file points to zebra-biblios-dom.xml but has 'zebra_bib_index_mode' set to grs1. The test incorrectly queried for 'zebra_auth_index_mode' being set to grs1.' To test: - Have a DOM setup. - Change koha-conf.xml so zebra_bib_index_mode = grs1 => FAIL: No configuration missmatch is shown. - Apply the patch - Reload the about page => SUCCESS: A zebra configuration missmatch is shown. (In reply to Tomás Cohen Arazi from comment #1) > - Reload the about page > => SUCCESS: A zebra configuration missmatch is shown. Without the patch, I get one warning. With the patch I get two. The first is a grs1 is deprecated message, which is valid. The second is bothersome, because it says I have dom set, but my koha-conf.xml was tweaked to grs1. It also says my configuration looks like it is for grs1, which I had it set up for dom before the single line configuration file tweak. So, the error triggered does not represent the actual problem. How should we proceed with this? Created attachment 38463 [details] [review] Bug 14006: about.pl checks the wrong zebra index mode When setting zebra_bib_index_mode to grs1 I get two warnings when not applying the patch: "The <zebra_bib_index_mode> entry is set to grs1. GRS-1 support is now deprecated and will be removed in future releases. Please use DOM instead by setting <zebra_bib_index_mode> to dom (full reindex required)." "You have set <use_zebra_facets> but the <zebra_bib_index_mode> is not set to dom. Falling back to legacy facet calculation." When applying the patch a third warning appears in addition to the two previous ones: "The <zebra_bib_index_mode> entry is set to dom, but your system still appears to be set up for grs1 indexing." Seems like the patch does what it should to me regarding the configuration mismatch warning. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Created attachment 38632 [details] [review] [PASSED QA] Bug 14006: about.pl checks the wrong zebra index mode When setting zebra_bib_index_mode to grs1 I get two warnings when not applying the patch: "The <zebra_bib_index_mode> entry is set to grs1. GRS-1 support is now deprecated and will be removed in future releases. Please use DOM instead by setting <zebra_bib_index_mode> to dom (full reindex required)." "You have set <use_zebra_facets> but the <zebra_bib_index_mode> is not set to dom. Falling back to legacy facet calculation." When applying the patch a third warning appears in addition to the two previous ones: "The <zebra_bib_index_mode> entry is set to dom, but your system still appears to be set up for grs1 indexing." Seems like the patch does what it should to me regarding the configuration mismatch warning. Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fix pushed to master. Pushed to 3.18.x will be in 3.18.7 Pushed to 3.16.x, will be in 3.16.11 |
about.pl has these lines: 104 if ( (C4::Context->config('zebra_bib_index_mode') eq 'dom') && ($context->{'server'}->{'biblioserver'}->{'config'} !~ /zebra-biblios-dom.cfg/) ) { 105 push @xml_config_warnings, { 106 error => 'zebra_bib_index_mode_mismatch_warn' 107 }; 108 } 109 110 if ( (C4::Context->config('zebra_auth_index_mode') eq 'grs1') && ($context->{'server'}->{'biblioserver'}->{'config'} =~ /zebra-biblios-dom.cfg/) ) { 111 push @xml_config_warnings, { 112 error => 'zebra_bib_index_mode_mismatch_warn' 113 }; 114 } I think line 110 should be looking at C4::Context->config('zebra_*bib*_index_mode'), not C4::Context->config('zebra_auth_index_mode')?