|
Description
Katrin Fischer
2015-04-17 12:53:51 UTC
Created attachment 38062 [details] [review] Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). (In reply to Katrin Fischer from comment #0) > To reproduce: > - search for a keyword in your reports that exists > - search works, correct reports are displayed > - search for a keyword in your reports, that doesn't exist > - result is correct and a nice message shown > - click "use saved" in the navigation to the left to return to your > full reports list > - nothing is shown, all reports are hiding. It was a feature, but did not work very well :) This patch should remove the ambiguity. Created attachment 38125 [details] [review] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Created attachment 38136 [details] [review] Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38137 [details] [review] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Oops... Signed off without including the "Depends on". Will re-test in 6+ hours. Retested with dependency. Sign-off holds. :) Created attachment 38211 [details] [review] [PASSED QA] Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38212 [details] [review] [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |