Bug 14014

Summary: Argument "" isn't numeric in numeric gt (>) in circulation.tt
Product: Koha Reporter: Marc Véron <veron>
Component: CirculationAssignee: Marc Véron <veron>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: chris, gmcharlt, kyle.m.hall, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14014 - Argument "" isn't numeric in numeric gt (>) in circulation.tt
Bug 14014 - Argument "" isn't numeric in numeric gt (>) in circulation.tt
Bug 14014 - Argument "" isn't numeric in numeric gt (>) in circulation.tt

Description Marc Véron 2015-04-19 19:02:59 UTC
intranet-error.log contains:

Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt line 217

Line 217:
[% IF ( RENTALCHARGE > 0 ) %]

RENTALCHARGE does not necessarily exist.
Comment 1 Marc Véron 2015-04-19 19:09:16 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2015-04-20 00:55:16 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-04-20 10:22:49 UTC
Created attachment 38171 [details] [review]
Bug 14014 - Argument "" isn't numeric in numeric gt (>) in circulation.tt

To test:

Do some checkouts
In intranet-error.log you get lines similar to:
circulation.pl: Argument "" isn't numeric in numeric gt (>) at /usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt line 217.

Apply patch
The warning  should no longer appear.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
To reproduce the confirmation message must be displayed.
Comment 4 Tomás Cohen Arazi 2015-04-20 13:29:18 UTC
Patch pushed to master.

Thanks Marc, we love getting rid of useless warnings :-D
Comment 5 Chris Cormack 2015-04-22 05:42:12 UTC
Pushed to 3.18.x will be in 3.18.6