|
Description
Katrin Fischer
2015-04-19 21:49:19 UTC
Created attachment 38161 [details] [review] Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. Created attachment 38198 [details] [review] Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Going to pass this patch as it fixes the checkouts tab, but the problem is still visible on the overdues tab - repeat test plan, but check out an item with a due date in the past, so that you get an overdues tab in the patron account. Created attachment 38210 [details] [review] [PASSED QA] Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38232 [details] [review] Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59) Same for the overdues. (In reply to Katrin Fischer from comment #3) > Going to pass this patch as it fixes the checkouts tab, but the problem is > still visible on the overdues tab - repeat test plan, but check out an item > with a due date in the past, so that you get an overdues tab in the patron > account. Yep, see last patch. It should be corrected in the same patchset. Created attachment 38292 [details] [review] [PASSED QA] Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59) Same for the overdues. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |