| Summary: | Ordering from suggestion shows 'copy. year:2014' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Marc Véron <veron> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14019 | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Enter and display a full suggestion
Display suggestion in "Add order from a suggestion" Bug 14018 - Ordering from suggestion shows 'copy. year:2014' Bug 14018 - Ordering from suggestion shows 'copy. year:2014' [PASSED QA] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' |
||
|
Description
Katrin Fischer
2015-04-20 05:46:50 UTC
Created attachment 38154 [details]
Enter and display a full suggestion
Screenshots with form for new suggestions, list display of suggestion and HTML.
The list display is handled in suggestion.tt line ca. 510 following.
Hi Marc, I think we are not looking in the same spot maybe? The display problem only occurs if you create an order from the suggestion afaikt - on the screen where you pick from the accepted orders. Created attachment 38169 [details]
Display suggestion in "Add order from a suggestion"
See 'copy year:2015' near ISBN
- We have a copyright date and a publication year in the database, but it seems that only the copyright date is used. The copyright date then pupulates the field "Publication year" in the "New order" form. - The forms for creating an new suggestion in staff client and OPAC display the copyright date only. - Both the list views in newordersuggestion.tt and suggestion.tt are prepared to display the copyright date and the publication year. - They display the same overall information in a slightly different way. - I think the display should be streamlined (using an include?) to have a more consistent and translation friendly display. For the moment I will replace the text 'copy. year.' with te copyright-sign (as it is in suggestion.tt) plus some similar minor changes ( 'in' instead of 'at' for publication place). For the streamlining I propose to have a separat bug because this will need some more analyzing. Created attachment 38172 [details] [review] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Created attachment 38609 [details] [review] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 38615 [details] [review] [PASSED QA] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Marc! Pushed to 3.18.x will be in 3.18.7 |