Bug 14022

Summary: Subscription form resets 'subscription length' to issues on editing
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: SerialsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, colin.campbell, jonathan.druart, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27398
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14022: Does not reset the subscription length on editing a subscription
[Signed-off] Bug 14022: Does not reset the subscription length on editing a subscription
[PASSED QA] Bug 14022: Does not reset the subscription length on editing a subscription

Description Katrin Fischer 2015-04-20 13:32:38 UTC
When editing a subscription the subscription length (second page) is reset to issues, even if the subscription was initially saved with a value in months or weeks.

This is more of a problem as it sounds even, as a high value in 'issues' can bring created a lot of load on the server with a lot of database requests and causes vry slow response times.
Comment 1 Jonathan Druart 2015-04-20 15:02:30 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-04-20 16:53:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2015-04-20 19:46:03 UTC
Created attachment 38209 [details] [review]
[PASSED QA] Bug 14022: Does not reset the subscription length on editing a subscription

The subscription length is always set to the first/default value
('issues') when editing a subscription.
Even if you selected another value on creating/editing it, the form will
show you the first option.

Test plan:
1/ Add/Edit a subscription, select a subscription length different of
the first value (issues)
2/ Edit the subscription and confirm the value is kept

Bonus: issues, week and months become translatable.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2015-04-23 15:14:00 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 5 Chris Cormack 2015-05-11 21:42:04 UTC
Pushed to 3.18.x will be in 3.18.7