Summary: | Fix 856u-links in the OPAC for NORMARC | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | OPAC | Assignee: | Magnus Enger <magnus> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14025 - Fix 865u-links in the OPAC for NORMARC
[SIGNED-OFF] Bug 14025 - Fix 865u-links in the OPAC for NORMARC Bug 14025 - Fix 865u-links in the OPAC for NORMARC |
Description
Magnus Enger
2015-04-20 15:54:06 UTC
Created attachment 38677 [details] [review] Bug 14025 - Fix 865u-links in the OPAC for NORMARC The display of links found in 856$u for NORMARC has not been keeping up with the one for MARC21, and several sysprefs have not been implemented. This patch tries to fix that. Affected sysprefs: - OPACURLOpenInNewWindow - URLLinkText - OPACDisplay856uAsImage - OPACTrackClicks To test: - Make sure you have a record with a URL in 856$u and marcflavor = NORMARC. (It does not have to be a full NORMARC setup or a NORMARC record, just make sure you are viewing the record through the NORMARC XSLT files.) - View the record both in a result list and in detail view - Check that the 4 involved sysprefs affect the display in the expected ways The scope of this bug changed a bit after I made the first comment, please disregard it. (In reply to Magnus Enger from comment #2) > The scope of this bug changed a bit after I made the first comment, please > disregard it. ...where "it" = the first comment (not the bug and the patch :-). Created attachment 39240 [details] [review] [SIGNED-OFF] Bug 14025 - Fix 865u-links in the OPAC for NORMARC The display of links found in 856$u for NORMARC has not been keeping up with the one for MARC21, and several sysprefs have not been implemented. This patch tries to fix that. Affected sysprefs: - OPACURLOpenInNewWindow - URLLinkText - OPACDisplay856uAsImage - OPACTrackClicks To test: - Make sure you have a record with a URL in 856$u and marcflavor = NORMARC. (It does not have to be a full NORMARC setup or a NORMARC record, just make sure you are viewing the record through the NORMARC XSLT files.) - View the record both in a result list and in detail view - Check that the 4 involved sysprefs affect the display in the expected ways Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on NORMARC setup and XSLTs Works as described, each syspref works No koha-qa errors Created attachment 39409 [details] [review] Bug 14025 - Fix 865u-links in the OPAC for NORMARC The display of links found in 856$u for NORMARC has not been keeping up with the one for MARC21, and several sysprefs have not been implemented. This patch tries to fix that. Affected sysprefs: - OPACURLOpenInNewWindow - URLLinkText - OPACDisplay856uAsImage - OPACTrackClicks To test: - Make sure you have a record with a URL in 856$u and marcflavor = NORMARC. (It does not have to be a full NORMARC setup or a NORMARC record, just make sure you are viewing the record through the NORMARC XSLT files.) - View the record both in a result list and in detail view - Check that the 4 involved sysprefs affect the display in the expected ways Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on NORMARC setup and XSLTs Works as described, each syspref works No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Since it only affects NORMAC, I trust in Magnus :) Patch pushed to master. Thanks Magnus! Pushed to 3.20.x will be in 3.20.1 Patch pushed to 3.18.x will be in 3.18.08 (In reply to Liz Rea from comment #8) > Patch pushed to 3.18.x will be in 3.18.08 hmm, i get a conflict on 3.16.x, will skip this patch for now.. |