Summary: | Capitalization: confirmation message on deleting an authority type | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, mtj, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14033 - Capitalization: confirmation message on deleting an authority type
Bug 14033 - Capitalization: confirmation message on deleting an authority type Bug 14033 - Capitalization: confirmation message on deleting an authority type [PASSED QA] Bug 14033 - Capitalization: confirmation message on deleting an authority type |
Description
Katrin Fischer
2015-04-21 05:38:09 UTC
Do you mean something like: Confirm deletion of authority structure definition for 'Uniform Title' (UNIF_TITLE) in cgi-bin/koha/admin/authtypes.pl?op=delete_confirm&authtypecode=UNIF_TITLE 'Uniform Title' comes from the description of this authority type. Or am I looking at the wrong place? :-) Try and delete one - it says: No, Do Not Delete... which is not what our rules say :) git grep 'No, Do' koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt Created attachment 38303 [details] [review] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Created attachment 38608 [details] [review] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Hi Marc, please also correct the 'Yes, Delete' and similar on those templates, so both messages match again. there are also some others, like: Delete this Currency (for yes). Created attachment 38633 [details] [review] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> --- Amended to replace more strings, see comment #6 / mv Created attachment 38686 [details] [review] [PASSED QA] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed some tabs. Patch pushed to master. Thanks Marc! Pushed to 3.18.x will be in 3.18.7 |