| Summary: | Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Zeno Tajoli <ztajoli> |
| Component: | Cataloging | Assignee: | Zeno Tajoli <ztajoli> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Sponsored | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Patch for sorting z39.50 servers
Patch for sorting z39.50 servers IN acq Bug 14047: Order z39.50 biblioservers in cataloguing Bug 14047: Sort z39.50 servers in Acquisition Bug 14047: [QA Follow-up] Move result_class back into attributes Bug 14047: Order z39.50 biblioservers in cataloguing |
||
|
Description
Zeno Tajoli
2015-04-22 14:42:53 UTC
Created attachment 38345 [details] [review] Patch for sorting z39.50 servers Zeno, same code is used in cataloguing/z3950_search.pl, you need to copy/paste your change. (That's exactly why I did not want to see DBIx::Class queries in pl files...) I meant acqui/z3950_search.pl Created attachment 39214 [details] [review] Patch for sorting z39.50 servers IN acq The patch is for acqui/z3950_search.pl To fix the bug you must applay the two patch. To test the second patch you need to use z39.50 inside an order into ACQ Created attachment 39286 [details] [review] Bug 14047: Order z39.50 biblioservers in cataloguing Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 39287 [details] [review] Bug 14047: Sort z39.50 servers in Acquisition Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 39288 [details] [review] Bug 14047: [QA Follow-up] Move result_class back into attributes No need to put this into a separate call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note that we strictly speaking do not need the hashref inflator here, because TT understands hash.column as well as object.property. Created attachment 39412 [details] [review] Bug 14047: Order z39.50 biblioservers in cataloguing Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 14047: Sort z39.50 servers in Acquisition Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 14047: [QA Follow-up] Move result_class back into attributes No need to put this into a separate call. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note that we strictly speaking do not need the hashref inflator here, because TT understands hash.column as well as object.property. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> To gain readability, I squashed the 3 patches. Marcel I hope you don't mind and you are fine with that. Patch pushed to master. Thanks Zeno! Pushed to 3.20.x will be in 3.20.1 |