| Summary: | 246 XSLT Improvements | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | MARC Bibliographic data support | Assignee: | Winona Salesky <wsalesky> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | indradg, jonathan.druart, m.de.rooy, nick, tomascohen, wsalesky |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14054 - 246 XSLT Improvements Add title type in brackets for field 246 based on 2nd indicator. Overridden by subfield i. Applies to OPAC and staff details.
Bug 14054 - 246 XSLT Improvements Bug 14054 - 246 XSLT Improvements Bug 14054 - 246 XSLT Improvements |
||
|
Description
Nicole C. Engard
2015-04-23 23:32:25 UTC
Created attachment 39831 [details] [review] Bug 14054 - 246 XSLT Improvements Add title type in brackets for field 246 based on 2nd indicator. Overridden by subfield i. Applies to OPAC and staff details. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 246 with populated ind2 4) Title types are added in brackets following title, unless subfield i exists. Then ind2 value is suppressed. 6) Repeat test for the staff interface Yay! It works! Thank you! And now a question: Should subfield i also go into brackets when it overrides the 2nd indicator? I think that would make it easier to read too. We could do that. Should the display force subfield i to occur at the end as with the titles generated by the indicator? (Makes the most sense to me.) (In reply to Nick Clemens from comment #2) > Yay! It works! Thank you! > > And now a question: > Should subfield i also go into brackets when it overrides the 2nd indicator? > I think that would make it easier to read too. > Should the display force subfield i to occur at the end as
> with the titles generated by the indicator? (Makes the most sense to me.)
I agree, that makes sense
Should this apply in both details and results view? Currently only implemented in details view, it may clutter up the results view to have it in both, but I'm flexible. -Winona (In reply to Nick Clemens from comment #4) > > Should the display force subfield i to occur at the end as > > with the titles generated by the indicator? (Makes the most sense to me.) > > I agree, that makes sense Created attachment 40020 [details] [review] Bug 14054 - 246 XSLT Improvements Adds other title type based on ind2 value. ind2 overridden by $i value. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 246 with populated ind2 4) Title types are added in brackets following title, unless subfield i exists. Then ind2 value is suppressed. 6) Repeat test for the staff interface Looking very good! Going back to the initial bug filing, I think 246 2nd indicator should display for first indicator either 0 or 1. According to MARC the values are: First Indicator Note/added entry controller 0 - Note, no added entry 1 - Note, added entry 2 - No note, no added entry 3 - No note, added entry I don't know if 2 or 3 actually means you are not supposed to display the title at all, but I always prefer seeing it so am not rocking that boat unless someone else wants to chime in. Anyone else have an opinion on the first indicator? Should 246 only display for ind1=1 or 0? Thanks! -Winona (In reply to Nick Clemens from comment #7) > Looking very good! > > Going back to the initial bug filing, I think 246 2nd indicator should > display for first indicator either 0 or 1. According to MARC the values are: > > First Indicator > Note/added entry controller > 0 - Note, no added entry > 1 - Note, added entry > 2 - No note, no added entry > 3 - No note, added entry > > I don't know if 2 or 3 actually means you are not supposed to display the > title at all, but I always prefer seeing it so am not rocking that boat > unless someone else wants to chime in. Created attachment 40212 [details] [review] Bug 14054 - 246 XSLT Improvements Adds other title type based on ind2 value. ind2 overridden by $i value. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Can I have a more detailed test plan please, I don't manage to see the difference pre and post patch. Created attachment 42802 [details] [review] Bug 14054 - 246 XSLT Improvements Adds other title type based on ind2 value. ind2 overridden by $i value. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> ok sorry, I was not using the correct XSLT file :-/ Patch pushed to master. Thanks Winona! Great! Thank you, -Winona (In reply to Tomás Cohen Arazi from comment #13) > Patch pushed to master. > > Thanks Winona! |