Bug 14056

Summary: Small punctuation error in description for deleting a holiday
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: ToolsAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: chris, mtompset, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 14056 - Small punctuation error in description for deleting a holiday
Bug 14056 - Small punctuation error in description for deleting a holiday
Bug 14056 - Small punctuation error in description for deleting a holiday
[PASSED QA] Bug 14056 - Small punctuation error in description for deleting a holiday

Description Aleisha Amohia 2015-04-24 03:17:42 UTC
When deleting a holiday in the calendar, the description for 'Delete the exceptions within a range" reads -->
"This will delete the exceptions inside a given range. Be careful about your scope range if it is oversized you could slow down Koha."

Small punctuation error here - should have a hyphen ie ".. Be careful about your scope range - if it is oversized you could slow down Koha."
Comment 1 Aleisha Amohia 2015-04-24 03:29:09 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2015-04-26 06:34:22 UTC
I'm not part of the grammar police, but it seems to me that hyphen is not the most natural and plain way of expressing this. Though, I definitely agree there needs a tweak somehow.

Perhaps:
Be careful about your scope range; if it is oversized, you could slow down Koha.
instead?
Comment 3 Aleisha Amohia 2015-04-28 02:08:05 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2015-04-28 04:05:01 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-04-28 20:37:46 UTC
Created attachment 38613 [details] [review]
[PASSED QA] Bug 14056 - Small punctuation error in description for deleting a holiday

This patch just inserts a semi-colon into the description so that it makes more grammatical sense.

Test plan:
1) Go to Tools --> Calendar
2) Create or find a holiday, click on it so the editing options come up
3) Click on the question mark link to show the description for the option "Delete the exceptions on a range"
4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha."

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2015-05-06 13:46:20 UTC
Patch pushed to master.

Thanks Aleisha!
Comment 7 Chris Cormack 2015-05-17 05:57:58 UTC
Pushed to 3.18.x will be in 3.18.7