| Summary: | Silence warnings t/Charset.t | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, indradg, jonathan.druart, mtj, tomascohen, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 8879 | ||
| Attachments: |
Bug 14112: Silence warnings in t/Charset.t
Bug 14112: Silence warnings in t/Charset.t Bug 14112: Silence warnings in t/Charset.t Bug 14112 - Silence warnings in t/Charset.t Bug 14112 - Silence warnings in t/Charset.t Bug 14112 - Silence warnings in t/Charset.t |
||
|
Description
Mark Tompsett
2015-05-01 19:48:47 UTC
Created attachment 38753 [details] [review] Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Created attachment 39014 [details] [review] Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Current status: Signed Off Created attachment 39015 [details] [review] Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN --------- 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> I am not sure it's the right way to fix it, have a look at http://perldoc.perl.org/perldiag.html#Character-following-%22\c%22-must-be-printable-ASCII Created attachment 39406 [details] [review] Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Created attachment 39545 [details] [review] Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 39570 [details] [review] Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN --------- 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Mark! Pushed to 3.20.x will be in 3.20.1 Patch pushed to 3.18.x will be in 3.18.08 Pushed to 3.16.x, will be in 3.16.13 |