Summary: | Silence noise t/Scrubber.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 8879 | ||
Attachments: |
Bug 14116: Silence noisy output for t/Scrubber.
[SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber. Bug 14116: Silence noisy output for t/Scrubber. Bug 14116: Clean up output, not just noise. Bug 14116: Silence noisy output for t/Scrubber. [SIGNED OFF] Bug 14116: Silence noisy output for t/Scrubber. [PASSED QA] Bug 14116: Silence noisy output for t/Scrubber. |
Description
Mark Tompsett
2015-05-02 01:16:27 UTC
Created attachment 38757 [details] [review] Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Created attachment 38906 [details] [review] [SIGNED-OFF] Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors Actually I think we should just put these strings as comments. I don't see any usefulness to print them. (In reply to Jonathan Druart from comment #3) > Actually I think we should just put these strings as comments. > I don't see any usefulness to print them. The point of the patch was to silence noise, not necessarily clean up output. ;) (In reply to M. Tompsett from comment #4) > (In reply to Jonathan Druart from comment #3) > > Actually I think we should just put these strings as comments. > > I don't see any usefulness to print them. > > The point of the patch was to silence noise, not necessarily clean up > output. ;) It only silences a part of the noise. New patch needed /me thinks. (In reply to Tomás Cohen Arazi from comment #5) > It only silences a part of the noise. New patch needed /me thinks. So, another commit on this bug? Or another bug report? Created attachment 39615 [details] [review] Bug 14116: Silence noisy output for t/Scrubber. Some diag's are better suited as prints. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors Created attachment 39616 [details] [review] Bug 14116: Clean up output, not just noise. Same test plan. Added second commit that needs sign off. Created attachment 39617 [details] [review] Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Created attachment 39619 [details] [review] [SIGNED OFF] Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 39694 [details] [review] [PASSED QA] Bug 14116: Silence noisy output for t/Scrubber. Why diag or print out things, unless it is -v? And why print anything except success or failure type messages? This cleans up the output. TEST PLAN --------- 1) $ prove t/Scrubber.t -- there's some noise. 2) apply patch 3) $ prove t/Scrubber.t -- noise issue resolved. Output is still reasonable for -v. 4) koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Mark! |