Summary: | Silence warnings t/DataTables/Members.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 8879 | ||
Attachments: |
Bug 14118: Silence warnings t/DataTables/Members.t
[SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t Bug 14118: Silence warnings t/DataTables/Members.t [COUNTER-PATCH] Bug 14118: Prevent to save a letter if an error occurred |
Description
Mark Tompsett
2015-05-02 02:11:24 UTC
I know that bug 8879 is just "prove ./t", but I think it is reasonable to extend that omnibus to include "prove -r ./t". Created attachment 38759 [details] [review] Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN ---------- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Created attachment 39229 [details] [review] [SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN ---------- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cleaned. No errors Comment on attachment 39229 [details] [review] [SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t Review of attachment 39229 [details] [review]: ----------------------------------------------------------------- Not blocker. ::: C4/Utils/DataTables/Members.pm @@ +103,4 @@ > > my $limit; > # If iDisplayLength == -1, we want to display all patrons > + if ( !$dt_params->{iDisplayLength} || $dt_params->{iDisplayLength} > -1 ) { What about if ( not $dt_params->{iDisplayLength} or $dt_params->{iDisplayLength} > -1 ) { @@ +107,3 @@ > # In order to avoid sql injection > + $dt_params->{iDisplayStart} =~ s/\D//g if defined($dt_params->{iDisplayStart}); > + $dt_params->{iDisplayLength} =~ s/\D//g if defined($dt_params->{iDisplayLength}); useless use of parenthesis. Created attachment 39386 [details] [review] Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN ---------- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Cleaned. No errors Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Created attachment 39387 [details] [review] [COUNTER-PATCH] Bug 14118: Prevent to save a letter if an error occurred On saving a letter, if the title or the content of a template is not defined, a JS alert is raised. But the form is submitted anyway. This patch prevent the form to be submitted. Test plan: - Create or edit a letter - Fill the title for a template, not the content - Save - Confirm you get the alert and that the form is not submitted Erk, wrong bug report. Sorry about that. Patch pushed to master. Thanks Mark! |