Summary: | Holds queue viewer only displays first subtitle from marc keyword mappings | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Hold requests | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, gmcharlt, gwilliams, jonathan.druart, melissa, tomascohen, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings
Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings |
Description
Kyle M Hall (khall)
2015-05-04 16:53:39 UTC
Created attachment 38825 [details] [review] Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear Created attachment 39809 [details] [review] Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings I've tested this patch and it works. Created attachment 39845 [details] [review] Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear Signed-off-by:Heather Braum <hbraum@nekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Kyle! Pushed to 3.20.x will be in 3.20.1 Hi, This patch doesn't apply for 3.18. If you feel that it should be included, please resolve any issues and resubmit a patch for inclusion in 3.18.x. Liz |