| Summary: | Show notices tab with EnhancedMessagingPreferences deactivated | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Ed Veal <edward.m.veal> |
| Component: | Patrons | Assignee: | Sophie MEYNIEUX <sophie.meynieux> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, kyle.m.hall, liz, sophie.meynieux, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display
Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display |
||
|
Description
Ed Veal
2015-05-06 14:17:04 UTC
Created attachment 44437 [details] [review] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Created attachment 44450 [details] [review] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 44457 [details] [review] [PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on EnhancedMessagingPreferences to display Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set to "Don't Allow", so Notices tab have to be visible in all cases. Test plan : - without patch : - set EnhancedMessagingPreference to "Don't Allow" and go to patron record : there is no Notices tab - set EnhancedMessagingPreference to "Allow" and og to patron record : there is a Notices tab - apply this patch : - go to patron record, you cas see a Notices tab - change the value of EnhanceMessagingPreferences, Notices tab is always visible. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This is a small change in behaviour, but as we have no preference for "UsesOverdueNotices" it's a quick fix. The tab can still be hidden with jQuery. It would be nice to have a follow up adding an id to the element, to make it even easier. Hm, I see it also checkes for "sentnotices". Patch pushed to master. Thanks Sophie! This patch has been pushed to 3.20.x, will be in 3.20.6. Pushed to 3.18.13, and released. |